Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unable to re-attach document in singleplayer mode #903

Closed
5 of 6 tasks
prajwalkulkarni opened this issue Feb 4, 2024 · 2 comments · Fixed by #910
Closed
5 of 6 tasks

Unable to re-attach document in singleplayer mode #903

prajwalkulkarni opened this issue Feb 4, 2024 · 2 comments · Fixed by #910
Assignees
@prajwalkulkarni
Labels
apps: marketing Issues related to website or marketing app Stale status: assigned Issue has been assigned type: enhancement Enhancing a existing feature

Comments

@prajwalkulkarni
Copy link
Contributor

Issue Description

I recently wanted to get my rent receipts signed by the landlord, so I headed over to single-player mode to start the signing process. I accidentally uploaded the wrong file and realized it after some time. I wanted to re-upload the correct document but there wasn't an easy way to do it. I had to navigate back and forth to start the process afresh, which is not very intuitive.

Steps to Reproduce

  1. Navigate to single-player mode (https://documenso.com/singleplayer)
  2. Upload any document
  3. Try removing and reuploading a new document without clicking on the back/forth button on the browser navbar.

Expected Behavior

We should be able to re-upload the document once any document is uploaded. The "Go back" button can be rendered as "Reupload" or something similar once the document is uploaded. Currently, it is unresponsive on step 1.
In addition, the progress bar is 50% complete simply by navigating to single-player mode and without having to upload any document. I feel the progress bar should update to 50% or any number after the user adds a document. I might be wrong here, but I'm just thinking out loud.

Current Behavior

Currently, there is no simple way to remove and add a new document, and the "Go back" button is unresponsive in Step 1.

Screenshots (optional)

No response

Operating System [e.g., Windows 10]

Windows 11

Browser [e.g., Chrome, Firefox]

Chrome

Version [e.g., 2.0.1]

Version 121.0.6167.140 (Official Build) (64-bit)

Please check the boxes that apply to this issue report.

  • I have searched the existing issues to make sure this is not a duplicate.
  • I have provided steps to reproduce the issue.
  • I have included relevant environment information.
  • I have included any relevant screenshots.
  • I understand that this is a voluntary contribution and that there is no guarantee of resolution.
  • I want to work on creating a PR for this issue if approved
@prajwalkulkarni prajwalkulkarni added the type: bug Something isn't working label Feb 4, 2024
@maige-app maige-app bot added help wanted Extra attention is needed Usability needs-testing Flagged for manual testing after merge in main. labels Feb 4, 2024
@github-actions github-actions bot added the status: triage Scope to be determined label Feb 4, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 4, 2024

Thank you for opening your first issue and for being a part of the open signing revolution!

One of our team members will review it and get back to you as soon as it possible 💚

Meanwhile, please feel free to hop into our community in Discord

@dguyen dguyen added type: enhancement Enhancing a existing feature status: assigned Issue has been assigned apps: marketing Issues related to website or marketing app and removed type: bug Something isn't working help wanted Extra attention is needed Usability needs-testing Flagged for manual testing after merge in main. status: triage Scope to be determined labels Feb 5, 2024
@dguyen
Copy link
Collaborator

dguyen commented Feb 5, 2024

We should be able to re-upload the document once any document is uploaded. The "Go back" button can be rendered as "Reupload" or something similar once the document is uploaded. Currently, it is unresponsive on step 1.

Makes sense, I've assigned it to you :)

In addition, the progress bar is 50% complete simply by navigating to single-player mode and without having to upload any document. I feel the progress bar should update to 50% or any number after the user adds a document. I might be wrong here, but I'm just thinking out loud.

I think it's fine currently, since if it's the other way the final step interaction would be strange where it's 1/2 until the user clicks submit

@prajwalkulkarni prajwalkulkarni mentioned this issue Feb 5, 2024
Merged
@github-actions github-actions bot added the Stale label May 5, 2024
Mythie added a commit that referenced this issue May 24, 2024
@Mythie
fix: Remove document on go back click on step 1 (#910)
ef5d267 
⭐ Fixes #903 
⭐ Invoke `onBackStep` on "Go Back" click and conditionally render
Go back label string.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@prajwalkulkarni prajwalkulkarni

Labels
apps: marketing Issues related to website or marketing app Stale status: assigned Issue has been assigned type: enhancement Enhancing a existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Remove document on go back click on step 1 prajwalkulkarni/documenso
2 participants
@dguyen @prajwalkulkarni