Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API token deletion not reflected in cache until page reload #1011

Open
6 tasks done
ashrafchowdury opened this issue Mar 9, 2024 · 17 comments · May be fixed by #1128
Open
6 tasks done

API token deletion not reflected in cache until page reload #1011

ashrafchowdury opened this issue Mar 9, 2024 · 17 comments · May be fixed by #1128
Labels
apps: web Issues related to the webapp component: ui User interface changes status: assigned Issue has been assigned type: bug Something isn't working

Comments

@ashrafchowdury
Copy link
Contributor

Issue Description

After deleting the API token, the token still persists in the cache. Despite the deletion process, the token remains accessible until the page is manually reloaded. This inconsistency poses a potential security risk.

Also, the 'Token expiration date' field is not clear after successfully creating the API token.

Steps to Reproduce

  1. Log in to the app,
  2. Navigate to the settings or profile section where API tokens are managed.
  3. Create a new API token.
  4. Then delete that API token.
  5. Notice that the deleted token is still accepted and functional.
  6. Manually reload the page to remove the token from the display

Expected Behavior

The API token should be immediately removed from the cache after successfully deleting it from the database.

Current Behavior

The API token remains accessible and functional even after deletion until the page is manually reloaded.

Screenshots (optional)

Untitled.video.-.Made.with.Clipchamp.mp4

Operating System [e.g., Windows 10]

Windows 11

Browser [e.g., Chrome, Firefox]

Chrome, Edge

Version [e.g., 2.0.1]

Latest

Please check the boxes that apply to this issue report.

  • I have searched the existing issues to make sure this is not a duplicate.
  • I have provided steps to reproduce the issue.
  • I have included relevant environment information.
  • I have included any relevant screenshots.
  • I understand that this is a voluntary contribution and that there is no guarantee of resolution.
  • I want to work on creating a PR for this issue if approved
@ashrafchowdury ashrafchowdury added the type: bug Something isn't working label Mar 9, 2024
@github-actions github-actions bot added the status: triage Scope to be determined label Mar 9, 2024
@ashrafchowdury
Copy link
Contributor Author

I would like to work on this issue if it gets approved.

@dguyen dguyen added status: assigned Issue has been assigned apps: web Issues related to the webapp component: ui User interface changes and removed status: triage Scope to be determined labels Mar 13, 2024
@dguyen
Copy link
Collaborator

dguyen commented Mar 13, 2024

Thanks, assigned it to you :)

@SaiSawant1
Copy link
Contributor

@ashrafchowdury are you working on this?

@ashrafchowdury
Copy link
Contributor Author

@ashrafchowdury are you working on this?

Yes.

@rushatgabhane
Copy link
Contributor

Hey, @ashrafchowdury it's been almost two months since you were assigned. How's it looking? Do you need help?

@rushatgabhane
Copy link
Contributor

I'd love to work on this issue if that's okay. I aim to complete it in 3 days

@ElTimuro
Copy link
Member

@ashrafchowdury are you actively working on this? Otherwise I'm reassigning tomorrow..

@ashrafchowdury
Copy link
Contributor Author

@ashrafchowdury are you actively working on this? Otherwise I'm reassigning tomorrow..

I'm really sorry for the late reply @ElTimuro, I not working on this issue currently feel free to assign someone else.

Again, I apologize for not taking any action on it.

@ashrafchowdury ashrafchowdury removed their assignment Apr 26, 2024
@ElTimuro
Copy link
Member

@rushatgabhane afaik you have another issue, you want to take this one as well? Please be mindful if 2 in parralel are too much :D

@ElTimuro
Copy link
Member

@ashrafchowdury it's fine, thanks for letting me know

@cchirag
Copy link

cchirag commented Apr 29, 2024

Can I work on this?

@ElTimuro
Copy link
Member

@cchirag
Copy link

cchirag commented Apr 29, 2024

Cool @ElTimuro . Let me know if @rushatgabhane chooses to decline. Thank you.

@cchirag cchirag linked a pull request Apr 29, 2024 that will close this issue
2 tasks
@rushatgabhane
Copy link
Contributor

rushatgabhane commented Apr 30, 2024

@ElTimuro i was interested, but it looks like @cchirag already raised a PR 😅
So maybe we just assign them, what do you think?

@cchirag
Copy link

cchirag commented Apr 30, 2024

Hey @rushatgabhane, sorry for picking up the task. The fix seemed straightforward and we had not heard from you in 4 days. But, I guess you can review my PR and maybe share it with us if you have a better approach.

@rushatgabhane
Copy link
Contributor

rushatgabhane commented Apr 30, 2024

@cchirag don't worry about it, it's all good : )

@cchirag
Copy link

cchirag commented Apr 30, 2024

Thanks man @rushatgabhane . @ElTimuro can you please review the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apps: web Issues related to the webapp component: ui User interface changes status: assigned Issue has been assigned type: bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants