UnitOfWork::getEntityChangeSet violates contract

[norkunas]

Maybe I don't understand how things should work with collections, but currently this is happening:

UnitOfWork::getEntityChangeSet method defines return as:

@return mixed[][]
@psalm-return array<string, array{mixed, mixed}>

But for example on this entity:

class Entity {
  public Collection $attributes;

  public function setAttributes(Collection $attributes) { $this->attributes = $attributes; }
}

Calling setAttributes() with a new collection then later to populate changeset calling UnitOfWork::computeChangeSets and then UnitOfWork::getEntityChangeSet returns array{attributes: Doctrine\ORM\PersistentCollection}

[greg0ire]

I made that change at part of #8484 , which is one among many, many PRs, and it's very possible that I messed up . Can you please send a PR to fix the situation? 🙏

[greg0ire]

Yes, the typehint is most probably wrong, since I added very hastily.

[norkunas]

Should it be also same in https://github.com/doctrine/orm/blob/2.9.x/lib/Doctrine/ORM/Event/PreUpdateEventArgs.php#L51 ?

[greg0ire]

Given the Psalm failure you get here, I would say yes: https://github.com/doctrine/orm/pull/8959/checks?check_run_id=3419339848

[norkunas]

I've checked source so this event is instantiated with $this->getEntityChangeSet($entity) so imho they should be same

[greg0ire]

Ok, then please change it too 🙏