Not valid filtering by DateTime for ArrayCollection

[vvasilenok]

Hi!

I found not valid behavior for ArrayCollection matching function.

$criteria = Criteria::create()
                ->where(Criteria::expr()->eq("date", $date));

$result = $this->meta->matching($criteria);

For ArrayCollection matching use code from

# Doctrine/Common/Collections/Expr/ClosureExpressionVisitor.php (lines 112 - 116)
switch ($comparison->getOperator()) {
   case Comparison::EQ:
      return function ($object) use ($field, $value) {
            return ClosureExpressionVisitor::getObjectFieldValue($object, $field) === $value;
}

But

$date1 = new DateTime('2016-09-05');
$date2 = new DateTime('2016-09-05');
$result = $date1 === $date2; ///false

$result = $date1 !== $date2; ///true

Need fix this.

[Ocramius]

This is normal behavior: comparing object fields will never work, since we
can't assume that an object field is a value object on our own.

Marco Pivetta

http://twitter.com/Ocramius

http://ocramius.github.com/

On Tue, Sep 6, 2016 at 9:55 AM, vvasilenok notifications@github.com wrote:

Hi!

I found not valid behavior for ArrayCollection matching function.

$criteria = Criteria::create()
->where(Criteria::expr()->eq("date", $date));

$result = $this->meta->matching($criteria);

For ArrayCollection matching use code from

Doctrine/Common/Collections/Expr/ClosureExpressionVisitor.php (lines 112 - 116)

switch ($comparison->getOperator()) {
case Comparison::EQ:
return function ($object) use ($field, $value) {
return ClosureExpressionVisitor::getObjectFieldValue($object, $field) === $value;
}

But

$date1 = new DateTime('2016-09-05');
$date2 = new DateTime('2016-09-05');
$result = $date1 === $date2; ///false

$result = $date1 !== $date2; ///true

Need fix this.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#93, or mute the thread
https://github.com/notifications/unsubscribe-auth/AAJakJ2VIK5iah3l8gF_nZzaFul3VEbnks5qnRx0gaJpZM4J1jyC
.

[vvasilenok]

Possibly add a not strict comparison? or replace current comparison to not strict? Or for DateTime use toString method?

[Ocramius]

Possibly add a not strict comparison?

non-strict comparison in PHP crashes with segfaults when there are infinite cycles/recursive data structures :-(

[vvasilenok]

But with strict comparison need write this code for correct work

        $reports = $project->getReports();
        if ($reports instanceof PersistentCollection && $reports->isInitialized()) {
            $criteria = Criteria::create()->where(Criteria::expr()->in('reportDate', [$date]));
        } else {
            $criteria = Criteria::create()->where(Criteria::expr()->eq('reportDate', $date));
        }


        return $reports->matching($criteria)->first();

I think this behavior is not expected when you use criteria

[elpoutro]

I really don't like this kind of freak but this solution work for me:

$criteria = Criteria::create()
    ->where(Criteria::expr()->gte("date", $date))
    ->andWhere(Criteria::expr()->lte("date", $date));

$result = $this->meta->matching($criteria);

I needed something that work if $this->meta is a Repository or an ArrayCollection. So i confirm this solution work for both.