Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Determine what to do with the BC layer for doctrine/common 2.2 at ExtensionMetadataFactory::getDriver() #2677

Closed
phansys opened this issue Aug 20, 2023 · 3 comments
Labels

Comments

@phansys
Copy link
Collaborator

phansys commented Aug 20, 2023

We need to confirm what is the purpose for the BC layer provided at ExtensionMetadataFactory::getDriver(), as it is not clear if this is intended to provide compatibility for doctrine/common >= 2.2.0 or doctrine/common < 2.2.0.

It seems confusing to me, as the commit where the change was introduced is also updating the constraint to "doctrine/common": ">=2.2,<2.4-dev". See 9e58bb7.

@stof
Copy link
Contributor

stof commented Oct 24, 2023

Actually, this comment was already there before that commit. See the deleted lines (it appears as added and deleted because its indentation has changed)

@stof
Copy link
Contributor

stof commented Oct 24, 2023

the comment was added in 01ca830

In doctrine/common 2.3+, the driver is an instance of MappingDriver

Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the Stale label Apr 21, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants