Skip to content
This repository has been archived by the owner on Oct 26, 2019. It is now read-only.

.dockerignore support? #327

Open
MiniCodeMonkey opened this issue Jul 5, 2018 · 1 comment
Open

.dockerignore support? #327

MiniCodeMonkey opened this issue Jul 5, 2018 · 1 comment

Comments

@MiniCodeMonkey
Copy link

Does this library support reading the .dockerignore file when creating a Context for building docker images?

I dug into https://github.com/docker-php/docker-php/blob/master/src/Context/Context.php but was not able to see any references.

I also dug into the official Docker CLI, and it appears (as far as I can understand) that the "excludes patterns" (aka .dockerignore contents) are sent directly to tar when building the context: https://github.com/moby/buildkit/blob/master/session/filesync/filesync.go#L104

If this feature is not currently available, I would be happy to take a stab at getting it implemented.

@otherguy
Copy link

otherguy commented Jul 5, 2018

Doesn’t it just call docker build basically? That would take care of the .dockerignore file support.

Easy enough to try though 🙂 Unfortunately I’m on my phone at the moment...

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants