Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docker-php-ext-disable #1277

Open
mvorisek opened this issue Mar 24, 2022 · 2 comments · May be fixed by #1281
Open

Add docker-php-ext-disable #1277

mvorisek opened this issue Mar 24, 2022 · 2 comments · May be fixed by #1281
Labels
Request Request for image modification or feature

Comments

@mvorisek
Copy link
Contributor

This is a feature request to add easy way to disable php ext.

I propose to add docker-php-ext-disable, but adding a switch --disable to current docker-php-ext-enable script will solve this issue as well.

The expected behaviour of disabling an ext is to rename the ini file to something like .ini-disabled and when enabling back, check if such ini file exists, if yes, strip the -disabled suffix, if no, create a new ini file.

@wglambert wglambert added the Request Request for image modification or feature label Mar 24, 2022
@tianon
Copy link
Member

tianon commented Mar 24, 2022

See #220 😅

@mvorisek
Copy link
Contributor Author

@tianon quite a lot of people demand this feature 😄

I belive the proposed solution here is better than simply rm the ini file, as the ini file might contain more configuration, and if so, this must be natively supported in docker-php-ext-enable to restore the disabled ini file

@mvorisek mvorisek linked a pull request Mar 26, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Request Request for image modification or feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants