Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed configured OPCache values for Maximun Perfomance in D8 #156

Closed
wants to merge 1 commit into from

Conversation

rolandocaldas
Copy link

@rolandocaldas rolandocaldas commented Oct 14, 2019

fixes #155

@yosifkit
Copy link
Member

I think this seems like a good change but this would need to also be done in Dockerfile-debian.template and Dockerfile-alpine.template, but if it shouldn't be applied to 7/, then we'll need to do something in update.sh to fix them.

Maybe something like this at the end of the for variant in fpm-alpine fpm apache; do loop?

# untested
if [ "$version" = '7' ]; then
	sed -ri \
		-e 's/(opcache.memory_consumption)=256/\1=128/' \
		-e 's/(opcache.max_accelerated_files)=20000/\1=4000/' \
		-e '/symfony/Id' \
	"$version/$variant/Dockerfile"
fi

@tianon
Copy link
Member

tianon commented Jun 8, 2022

This would probably be easier to implement in the templates themselves now with #190 👀

(No more hacky sed expressions 😅)

I'm going to close for now, but would love to see a new PR that implements this (especially one that links to the appropriate Drupal/Symphony documentation for where this recommendation comes from 👍).

@tianon tianon closed this Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change default OPcache configure values for Maximum Perfomance
3 participants