Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update documentation for CA certificate support changes #556

Open
tellison opened this issue May 9, 2024 · 5 comments · May be fixed by docker-library/docs#2445
Open

Update documentation for CA certificate support changes #556

tellison opened this issue May 9, 2024 · 5 comments · May be fixed by docker-library/docs#2445
Assignees
@rassie

Comments

@tellison
Copy link
Contributor

tellison commented May 9, 2024

Check and update the "Can I add my internal CA certificates to the truststore?" section of the official image documentation to reflect the latest updates one they are published.
@tellison
Copy link
Contributor Author

tellison commented May 9, 2024

@rassie are you ok to take this task?

@rassie
Copy link
Contributor

rassie commented May 9, 2024

Yeah, sure, I wanted to have prepared a PR for that before the feature PR had been merged, but thought I had a bit more time, it has been accepted with less discussion than I anticipated. Will take a couple of days though, so if someone else would like to a stab before that, they are welcome to do so.

@tellison
Copy link
Contributor Author

tellison commented May 9, 2024

Yeah, sure, I wanted to have prepared a PR for that before the feature PR had been merged, but thought I had a bit more time, it has been accepted with less discussion than I anticipated. Will take a couple of days though, so if someone else would like to a stab before that, they are welcome to do so.

Apologies if it was merged sooner than expected. The PR was not draft and had undergone reviews and approvals. It can be reverted if you think it is not ready.

@tellison tellison mentioned this issue May 9, 2024
Open
@rassie
Copy link
Contributor

rassie commented May 9, 2024 •
edited

No no, it's fine. I just thought it would raise more discussions, but in the end seemed to be good enough.

@rassie rassie linked a pull request May 10, 2024 that will close this issue
Open
@rassie
Copy link
Contributor

rassie commented May 10, 2024

Opened docker-library/docs#2445.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rassie rassie

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update eclipse-temurin docs about CA certs on non-root images rassie/docs
2 participants
@rassie @tellison