Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doccano-client does not support urllib3 2.0.0 #158

Open
baruch11 opened this issue Dec 13, 2023 · 2 comments · May be fixed by #159
Open

doccano-client does not support urllib3 2.0.0 #158

baruch11 opened this issue Dec 13, 2023 · 2 comments · May be fixed by #159

Comments

@baruch11
Copy link

baruch11 commented Dec 13, 2023 •
edited

How to reproduce the behaviour

I use poetry in my project. I just added doccano-client ("poetry add doccano-client"). My pyproject.toml looks like

[tool.poetry]
name = "poetry-demo"
version = "0.1.0"
description = ""
authors = ["CHARLES-HENRI PRAT"]
readme = "README.md"

[tool.poetry.dependencies]
python = "^3.10"
doccano-client = "^1.2.8"

[build-system]
requires = ["poetry-core"]
build-backend = "poetry.core.masonry.api"

And then when I just run python -c "import requests_toolbelt" I get this error
ImportError: cannot import name 'appengine' from 'urllib3.contrib' (/Users/charlesprat/RepoGit/poetry-demo/.venv/lib/python3.10/site-packages/urllib3/contrib/init.py)

Quick Fix

If I put a constraint on urllib3 version (poetry add urllib3@1.26), the error disappears.

Your Environment

  • Operating System: Mac OS 14.1.1 (23B81)
  • Python Version: 3.10
  • Package Version: 1.2.8
@ledurnan
Copy link

The following version bumps are required For compatibility with urllib3 2.0:

requests-toolbelt (0.9.1 -> 1.0.0)
vcrpy (4.3.0 -> 4.4.0)

For me, it was types-requests floating up which prompted this issue:

poetry show urllib3
 name         : urllib3                                                                
 version      : 2.1.0                                                                  
 description  : HTTP library with thread-safe connection pooling, file post, and more. 

required by
 - requests >=1.21.1,<3
 - responses >=1.25.10
 - types-requests >=2

@ledurnan ledurnan linked a pull request Dec 22, 2023 that will close this issue
Open
@baruch11
Copy link
Author

Thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix compatibility with urllib3 2.0 (bump vcrpy, requests-toolbelt) ledurnan/doccano-client
2 participants
@ledurnan @baruch11