Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump to latest tensorflow version #1776

Open
samsja opened this issue Sep 6, 2023 · 6 comments
Open

chore: bump to latest tensorflow version #1776

samsja opened this issue Sep 6, 2023 · 6 comments

Comments

@samsja
Copy link
Member

samsja commented Sep 6, 2023

Context

Tensorflow now supports proto 4 https://github.com/tensorflow/tensorflow/blob/master/requirements_lock_3_10.txt#L314.

We should bump tensorflow version in the pyproject.toml to latest version that support proto4

@JohannesMessner JohannesMessner changed the title Bump the lates tensorflow version chore: bump to latest tensorflow version Sep 6, 2023
@JohannesMessner
Copy link
Member

I don't think we have a tf version specified at all right now, we just install a certain version in the test CI.
If we now specify this new version that would imply dropping support for all older versions, right?

@samsja
Copy link
Member Author

samsja commented Sep 6, 2023

If we now specify this new version that would imply dropping support for all older versions, right?

yes

I don't think we have a tf version specified at all right now
We don't have a tensorflow version specified because proto version was caped on tensorflow.

This would allow us to have proper dependency management for tensorflow

@JoanFM
Copy link
Member

JoanFM commented Sep 6, 2023

But here u are proposing only to cap the TF version to a minimum version? If we do not have any reason not to support the previous versions, what would be the benefit?

@samsja
Copy link
Member Author

samsja commented Sep 6, 2023

But here u are proposing only to cap the TF version to a minimum version? If we do not have any reason not to support the previous versions, what would be the benefit?

benefit would be that tensorflow could be registered as a dependency in docarray.

As of today no package manager know that docarray can have tensorflow has a dependecy

@JohannesMessner
Copy link
Member

But here u are proposing only to cap the TF version to a minimum version? If we do not have any reason not to support the previous versions, what would be the benefit?

benefit would be that tensorflow could be registered as a dependency in docarray.

As of today no package manager know that docarray can have tensorflow has a dependecy

That seems more like a benefit to our dev workflow rather than a user benefit.
Yes, it would be nice for them to do pip install docarray[tf], but in return making it incompatible with every but the very newest tf version doesn't seem like a good tradeoff to me.

@samsja
Copy link
Member Author

samsja commented Sep 6, 2023

well not only our dev workflow but the dev workflow of our user ...

But yeah I see the argument, lets keep it like this then, but in 6 month probably we should reconsider

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo/Bug
Development

No branches or pull requests

3 participants