-
Notifications
You must be signed in to change notification settings - Fork 222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: bump to latest tensorflow version #1776
Comments
I don't think we have a tf version specified at all right now, we just install a certain version in the test CI. |
yes
This would allow us to have proper dependency management for tensorflow |
But here u are proposing only to cap the TF version to a minimum version? If we do not have any reason not to support the previous versions, what would be the benefit? |
benefit would be that tensorflow could be registered as a dependency in docarray. As of today no package manager know that docarray can have tensorflow has a dependecy |
That seems more like a benefit to our dev workflow rather than a user benefit. |
well not only our dev workflow but the dev workflow of our user ... But yeah I see the argument, lets keep it like this then, but in 6 month probably we should reconsider |
Context
Tensorflow now supports proto 4 https://github.com/tensorflow/tensorflow/blob/master/requirements_lock_3_10.txt#L314.
We should bump tensorflow version in the pyproject.toml to latest version that support proto4
The text was updated successfully, but these errors were encountered: