Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ServerFailedException ends ExtendedResolver resolution #247

Open
nathankurtyka opened this issue Feb 24, 2022 · 1 comment
Open

ServerFailedException ends ExtendedResolver resolution #247

nathankurtyka opened this issue Feb 24, 2022 · 1 comment

Comments

@nathankurtyka
Copy link

Shouldn't a ServerFailedException simply invoke the next SimpleResolver? Currently, a (possibly transient) DNS error response seems to be irrecoverable.

Or is there a workaround I'm not seeing?

@ibauersachs
Copy link
Member

Sorry for not getting back to this earlier.

ServerFailedException is created from a SERVFAIL response in LookupSession, regardless of the used resolver. If you're using a SimpleResolver this naturally ends the lookup.

For ExtendedResolver, well, good question. A SERVFAIL response is not a network error and thus is considered a completed lookup. I guess there could be a (new) option added to ExtendedResolver that continues on SERVFAIL responses.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants