Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: Add Limits for search result #6033

Closed
3 of 4 tasks
Mostafa-Moafi opened this issue May 13, 2024 · 0 comments · Fixed by #6034
Closed
3 of 4 tasks

[Enhancement]: Add Limits for search result #6033

Mostafa-Moafi opened this issue May 13, 2024 · 0 comments · Fixed by #6034

Comments

@Mostafa-Moafi
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Description of problem

There is a search service between the content and the blog, which contains a parameter called pageSize. The attacker can change the output value of the program by increasing this parameter. For example, by increasing this number, the output of the program can be several megabytes.
This problem causes the query of the program with the database to run longer and in case of successive attacks, it will cause the server to waste resources and eventually fail.

this service is /API/internalservices/searchService/search in DotNetNuke.Web project

Description of solution

we can add a number to maximum page sizes in SearchServiceController

Description of alternatives considered

No response

Anything else?

No response

Do you be plan to contribute code for this enhancement?

  • Yes

Would you be interested in sponsoring this enhancement?

  • Yes

Code of Conduct

  • I agree to follow this project's Code of Conduct
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant