Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement]: Add Dependency Injection Support for SkinController #5837

Open
3 of 4 tasks
GerardSmit opened this issue Oct 10, 2023 · 0 comments · May be fixed by #5838
Open
3 of 4 tasks

[Enhancement]: Add Dependency Injection Support for SkinController #5837

GerardSmit opened this issue Oct 10, 2023 · 0 comments · May be fixed by #5838
Labels
Status: New

Comments

@GerardSmit
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Description of problem

The current implementation of SkinController does not have abstraction layer that can be used with dependency injection.

Description of solution

Create an interface for this class called ISkinService.

Description of alternatives considered

Don't add an interface and keep on using SkinController.

Anything else?

No response

Do you be plan to contribute code for this enhancement?

  • Yes

Would you be interested in sponsoring this enhancement?

  • Yes

Code of Conduct

  • I agree to follow this project's Code of Conduct
GerardSmit added a commit to GerardSmit/Dnn.Platform that referenced this issue Oct 10, 2023
@GerardSmit
Add ISkinService for Abstractions Project
15f2053 
Fixes dnnsoftware#5837
@GerardSmit GerardSmit linked a pull request Oct 10, 2023 that will close this issue
Open
bdukes pushed a commit to GerardSmit/Dnn.Platform that referenced this issue Oct 24, 2023
@GerardSmit @bdukes
Add ISkinService for Abstractions Project
b9eb1ac 
Fixes dnnsoftware#5837
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Status: New
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add ISkinService for Abstractions Project GerardSmit/Dnn.Platform
1 participant
@GerardSmit