Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable button color #36

Open
jjhesk opened this issue Mar 9, 2015 · 8 comments
Open

disable button color #36

jjhesk opened this issue Mar 9, 2015 · 8 comments
Assignees

Comments

@jjhesk
Copy link

jjhesk commented Mar 9, 2015

Is that possible to add disable button color when the button is triggered with setEnable(false); or starting status with enable == false?

@AdamCopperfield
Copy link

Any chance to get that?

@redwerk
Copy link

redwerk commented Dec 24, 2015

Hi @dmytrodanylyk ,

I'm interested in the implementation of this feature, and could do the PR, if you have no developments on this issue.

Thanks!

@dmytrodanylyk
Copy link
Owner

@redwerk please do.

@redwerk
Copy link

redwerk commented Dec 28, 2015

Hi @dmytrodanylyk,

Just a few questions about implementation.
Do we need to save\restore state of the button on enabled\disabled or just set the background color on setEnabled(false)?
Will user be able to setProgress when the button is disabled?

Thanks!

@dmytrodanylyk
Copy link
Owner

@redwerk I will check PR on weekends. Got a lot of work, sorry.

Do we need to save\restore state of the button on enabled\disabled or just set the background color on setEnabled(false)?
Will user be able to setProgress when the button is disabled?

Hmm... you don't need to use setEnabled method and change button color. If you want to make button not clickable just override touch listener and return true / false when button is in progress.

@redwerk
Copy link

redwerk commented Jan 4, 2016

@dmytrodanylyk I'm sorry, but I think we do not understand each other.
As described by @jjhesk, the color of the button should change when setEnabled (false) fire. And that's what I'm doing now.
But there are two questions.
Should we save\restore the state of the button (e.g. progress) at setEnabled (true) \ setEnabled (false)?
And will the user be able to use setProgress () when the button is disabled in order to avoid problems with the UI?
With these questions, I just want to clarify the best way for implementation of this feature.

Thanks!

@dmytrodanylyk
Copy link
Owner

Should we save\restore the state of the button (e.g. progress) at setEnabled (true) \ setEnabled (false)?

Yes

And will the user be able to use setProgress () when the button is disabled in order to avoid problems with the UI?

Yes, we want to disable button just to make sure user will not click on it again, when it's in progress state.

@redwerk
Copy link

redwerk commented Jan 11, 2016

Hi,

Here is PR #50

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants