Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support "struct of arrays" based complex numbers #60

Open
leofang opened this issue Feb 8, 2021 · 2 comments
Open

Support "struct of arrays" based complex numbers #60

leofang opened this issue Feb 8, 2021 · 2 comments

Comments

@leofang
Copy link
Contributor

leofang commented Feb 8, 2021

Follow-up of #50.

In #58, kDLComplex was added to support "array of structs" based complex numbers, which is the compact memory layout used in C/C++/Python/etc. However, as pointed out in #50 there is a need to support the "struct of arrays" layout as well (a struct containing two pointers for real and imag). This issue is to track such a need.
This was referenced Feb 8, 2021
Merged
Closed
@tqchen tqchen closed this as completed Jan 4, 2023
@leofang
Copy link
Contributor Author

leofang commented Jan 5, 2023

Hi @tqchen, I may have missed something -- is there any PR that addressed the SoA need?

@tqchen
Copy link
Member

tqchen commented Jan 5, 2023

Sorry, I thought it was refering to the AoS approach when skiming through, feel free to reopen

@tqchen tqchen reopened this Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tqchen @leofang