Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor RecurrenceRule class #118

Open
dmfs opened this issue Mar 5, 2023 · 0 comments
Open

Refactor RecurrenceRule class #118

dmfs opened this issue Mar 5, 2023 · 0 comments

Comments

@dmfs
Copy link
Owner

dmfs commented Mar 5, 2023

The RecurrenceRule class contains about 1500 lines of code (not counting blank lines, JavaDoc and comments), about 30% of the entire library. It really needs to be split into multiple classes. That way we also gain more flexibility.
First candidates are:

  • create dedicated Iterator classes and deprecate the iterator methods
  • externalize serialization to String, this way we can provide other options, e.g. regarding inclusion of default values (Interval not set if it is one #95)

Moving the enums to top level classes would be a breaking change that needs to be be considered carefully.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant