Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add_points() does not handle objective functions that output integers #46

Open
sjohnson-FLL opened this issue Jan 4, 2023 · 0 comments

Comments

@sjohnson-FLL
Copy link

In surrogate.py, in the add_points() method, an AttributeError exception is raised by calling fx.ndim (line 64) when fx is an integer.

Potential solutions:

  1. On line 62, expand type-checking to include integers as well as floats and update comment on line 59 accordingly.
  2. Update documentation here to specify that the eval method must return a float. The comments inside add_points() already reflect this, but the documentation on readthedocs.io does not.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant