Replace weather api example with github in create a pipeline walkthrough #1351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for dlt-hub-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
sultaniman
changed the title
sultaniman
changed the title
rudolfix
requested changes
May 13, 2024
sultaniman
force-pushed
the
docs/issue-1350-update-create-pipeline-tutorial
branch
from
8c48a76
to
893c68b
Compare
|
@AstrakhantsevaAA the problem with WeatherAPI is that it requires custom pagination which will be out of scope for this task, so the simple solution here is to go with GitHub API |
burnash
reviewed
May 15, 2024
burnash
requested changes
May 15, 2024
Co-authored-by: Anton Burnashev <anton.burnashev@gmail.com>
Co-authored-by: Anton Burnashev <anton.burnashev@gmail.com>
Co-authored-by: Anton Burnashev <anton.burnashev@gmail.com>
Co-authored-by: Anton Burnashev <anton.burnashev@gmail.com>
sultaniman
force-pushed
the
docs/issue-1350-update-create-pipeline-tutorial
branch
from
2919ecb
to
cb43a10
Compare
burnash
reviewed
May 16, 2024
burnash
reviewed
May 16, 2024
burnash
reviewed
May 16, 2024
burnash
approved these changes
May 16, 2024
|
@burnash thanks! I think you have to merge this because I don't have permissions to merge on failing CI items. |
|
Thanks @sultaniman the CI should be fixed in #1364 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates a walkthrough (Create a pipeline): Create a pipeline
Closes: #1350