Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix up some small edge cases #138

Open
5 tasks
dlareau opened this issue May 14, 2020 · 0 comments
Open
5 tasks

Fix up some small edge cases #138

dlareau opened this issue May 14, 2020 · 0 comments
Labels
bug Easy Easy to implement

Comments

@dlareau
Copy link
Owner

dlareau commented May 14, 2020

There are currently a few small edge cases that come up rarely but should be properly dealt with to avoid 500 errors whenever possible. They are gathered here to avoid creating 5 small issues that will be resolved hopefully quickly.

  • Create try/except wrapper or check to deal with the cases where there is a user with no associated person object. This usually happens when a staff member manually creates or edits a user and forgets to create or edit the person object.
  • Fix what happens when a staff member who is not on a team tries to submit an answer. Currently we 500 error, but we should do something nicer like 400, use the dummy account, or prompt the staff member to create a team. This only applies to staff as the checks for a normal user forbid the user from viewing the puzzle page without a team.
  • Currently refreshing the registration page after leaving a team fails because it submits the post request again (I think?) and it tries to take the user off a team they aren't on. This should either just quietly fail in the background (because it doesn't matter) or I should figure out how to avoid the whole re-POST thing.
  • Don't allow teams to be created after the hunt ends. Its just confusing and useless.
  • Don't allow submissions to be created after a puzzle has been solved. The text box automatically goes away for the user who entered the submission, but it takes till the next ajax request (up to 2 minutes due to exponential backoff) for other team members. Simply respond with some message like "You have already solved this puzzle"
@dlareau dlareau added bug Easy Easy to implement labels May 14, 2020
@dlareau dlareau added this to the V4.1 milestone May 14, 2020
@dlareau dlareau removed this from the V4.2 milestone Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Easy Easy to implement
Projects
None yet
Development

No branches or pull requests

1 participant