-
-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Point out common mistakes #8
Comments
We can get the diff nicely from the GH API: https://patch-diff.githubusercontent.com/raw/dlang/phobos/pull/4900.diff so the logic could be as simple as:
However I am not sure whether this will work for DMD / Druntime and it's worth risking the potential false positives. |
We should rather simplify our CI systems than adding an interpret layer on top of this. |
I just found this CI tool: http://danger.systems A couple of ideas from them:
Other ideas to check for:
For all warnings / errors of course we should provide links with a detailed explanation. CCing @JackStouffer for more ideas as he has done quite a bit of reviews at Phobos over the last year. |
Especially forgetting to point bug fixes at |
|
Especially at Phobos it's a lot of work to point out common mistakes and I think we should automate this. An incomplete list of common mistakes
make -f posix.mak style
4) ...
Another big problem is that test failures are often hard to interpret for newcomers. Maybe we could have a simple heuristic that comments if there has been a failure and the user has submitted less than five PRs to Phobos with helpful information about how to deal with CI errors?
The text was updated successfully, but these errors were encountered: