Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update last commit message when merging with links to the PR and its title #262

Open
PetarKirov opened this issue Nov 26, 2020 · 1 comment

Comments

@PetarKirov
Copy link
Member

When dlang-bot does auto-merge-rebase or auto-merge-squash, it should update the message of the commit that the branch head points to with information like:

Merged-on-behalf-of: <reviewer>
Pull-Request: <url>
Pull-Request-Title:<text>
Pull-Request-Description: <text>
@CyberShadow
Copy link
Member

Pull-Request:

The pull request number should always be on the first line. (This wasn't the case when the other merge methods were first introduced.)

Pull-Request-Title:

The first line should already be the pull request title.

Pull-Request-Description:

The description often contains information for reviewers, and thus usually doesn't need to be included in Git history.

Have I missed anything?

See also #181 and #66.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants