Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag alpha / beta release as pre-release #202

Open
Geod24 opened this issue Oct 17, 2018 · 9 comments
Open

Tag alpha / beta release as pre-release #202

Geod24 opened this issue Oct 17, 2018 · 9 comments

Comments

@Geod24
Copy link
Member

Geod24 commented Oct 17, 2018

Currently when a release is made, it's tagged as "Latest release", e.g. https://github.com/dlang/dub/releases/tag/v1.12.0-beta.1

This cause all tools using the latest release to start using the beta immediately.

@wilzbach
Copy link
Member

wilzbach commented Oct 17, 2018

That's not done by dlang-bot per se.
See https://github.com/dlang/dub/blob/master/.travis.yml and travis-ci/dpl#234 and dlang/dub#1367 (comment)

This cause all tools using the latest release to start using the beta immediately.

No, they query this: https://dlang.github.io/dub/LATEST (from the gh-pages branch)

On the contrary, the LATEST number hasn't been change for a while: https://github.com/dlang/dub/blob/gh-pages/LATEST (the automatic deployment seems to be defect)

Anyway I created a PR to set the prerelease status for the GitHub Releases: dlang/dub#1578
Though this won't help your problem.

@Geod24
Copy link
Member Author

Geod24 commented Oct 17, 2018

Okay, not all tools 🙂
But it does affect Buildkite for sure, doesn't it ? That's what triggered this issue.

@wilzbach
Copy link
Member

Uhm Buildkite always uses the get latest stable release script:

https://github.com/dlang/ci/blob/master/buildkite/build_project.sh

In short:

git ls-remote --tags https://github.com/dlang/dub | sed -n 's|.*refs/tags/\(v\?[0-9]*\.[0-9]*\.[0-9]*$\)|\1|p' | sort --version-sort | tail -n5
v1.8.0
v1.8.1
v1.9.0
v1.10.0
v1.11.0 <- should be selected

@wilzbach
Copy link
Member

image

@wilzbach
Copy link
Member

The real failure is:

�[0;33m[INFO] Running /var/lib/buildkite-agent/builds/buildkite-agent-05-1/dlang/dmd/build/dlang-dub/test/interactive-remove.sh...�[0m
Package dub not found for registry at https://code.dlang.org/ (fallback ["registry at http://code.dlang.org/", "registry at https://code-mirror.dlang.io/", "registry at https://code-mirror2.dlang.io/", "registry at https://dub-registry.herokuapp.com/"]): No package candidate found for dub 0.9.20
No package dub was found matching the dependency 0.9.20
Fetching dub 0.9.21...
[ERROR] /var/lib/buildkite-agent/builds/buildkite-agent-05-1/dlang/dmd/build/dlang-dub/test/interactive-remove.sh:10 command failed

@wilzbach
Copy link
Member

The tag is missing:

image

I don't know who deleted them, but someone did.

image

@wilzbach
Copy link
Member

CC @s-ludwig @MartinNowak

@wilzbach
Copy link
Member

Okay in the web UI the tags aren't there:

https://github.com/dlang/dub/tags?after=v0.9.22-beta.2

But ls-remote still shows them, e.g.

git ls-remote --tags https://github.com/dlang/dub

Maybe it's a GitHub issue? (I contacted the support)

@wilzbach
Copy link
Member

Workaround: dlang/ci#318 and dlang/dub#1579

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants