Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal - Add support for large display devices (Tablets or devices with landscape orientation) #63

Open
arutemu opened this issue Apr 7, 2024 · 5 comments

Comments

@arutemu
Copy link

arutemu commented Apr 7, 2024

The UI of the AmpRack (as of version 4) works perfectly fine with most mobile devices' screens of small or medium size.

However, it's not working great for tablets.

Main issues are

  • the app doesn't support the landscape orientation
  • the app doesn't support a horizontal list view of plugins
  • also the app doesn't work correctly in the multi-window mode that is available on Android devices with big screens (it crashes during resizing the app)

Note that some of these troubles can be avoided with the usage of developer options like

  • allow all apps to work in landscape orientation
  • allow all apps to work with the multi-window mode

However, there would still be a few issues even with such workarounds.

The current app UI in such cases looks like this:
Screenshot_20240408_021444_Amp Rack
The crash is also observable during this action:
Screenshot_20240408_021714_Songsterr

My purpose is to implement a few things of different complexity to help with it.

  1. Add support for landscape device orientation
  • most of the app UI will still work fine, except for the list of plugins
  1. Change the list of plugins to support a horizontal element view
  • on devices with a big display: change the Column with the list of plugins to a Row
  • in such cases set a default Plugin element width (for example, like 360.dp)
@djshaji
Copy link
Owner

djshaji commented Apr 14, 2024

Hi,

I've done some work on this. I've combined some UI elements so that the user experience is a little more usable on tablets.

Do try it out and see if I've broken anything. I've only tested it on an emulator, and it's only just some minor UI redesign, so everything should be as functional as before.

Download APK:
https://github.com/djshaji/amp-rack/releases/tag/4.03-tablet

See also #58

tab4
tab3
tab2
tab1

@arutemu
Copy link
Author

arutemu commented Apr 20, 2024

Finally can update this issue, yay.

First of all - thanks for the update.
The good news is that most of the app is working fine and no critical crashes were found.

However, there are quite a few issues with the UI layout on the big screen, as well as a few broken things now.
Will list them below.

@arutemu
Copy link
Author

arutemu commented Apr 20, 2024

The first issue, the most minor one, is the merged Quick screen.
While there is no bug, it looks a bit strange and it's not clear which preset is currently selected.

I would propose duplicating the mixer/tuner panel to be added here, between the switch arrows.
It contains the indicator of the current preset.
Screenshot_20240420_234711_Amp Rack

@arutemu
Copy link
Author

arutemu commented Apr 20, 2024

There are also a few issues on the Effects screen.

  1. The user is not able to scroll to the end of the list of plugins, it's covered by the Bottom Navigation Bar.
  2. The minor issue, but I would propose to leave only 1 Top App Bar with all the buttons on it.
    Screenshot_20240420_225119_Amp Rack

@arutemu
Copy link
Author

arutemu commented Apr 20, 2024

I like the idea of merging the Recordings screen with the Drums screen.

And overall the UI looks fine.
However, it looks like there are some conflicts in the code of the both tabs.

  1. After clicking on the Play button on the Recordings tab, part of the Drums tab UI disappears (or is covered by some UI element).
    Screenshot_20240416_223101_Amp Rack

  2. After clicking on the Play button on the Drums tab, the Play button on the Recordings tab may be triggered as well.
    Note that I found no clear steps to reproduce this one issue.
    Screenshot_20240415_171726_Amp Rack

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants