{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":59369036,"defaultBranch":"master","name":"vpnkit","ownerLogin":"djs55","currentUserCanPush":false,"isFork":true,"isEmpty":false,"createdAt":"2016-05-21T16:06:30.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/198586?v=4","public":true,"private":false,"isOrgOwned":false},"refInfo":{"name":"","listCacheKey":"v0:1681234732.0","currentOid":""},"activityList":{"items":[{"before":"2dc2744dd8eff6037be5c330076869c377b5b3a1","after":"6a5c3c5cb0229a4982dad82207863299207bdf06","ref":"refs/heads/master","pushedAt":"2023-04-12T09:01:32.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"djs55","name":"David Scott","path":"/djs55","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/198586?s=80&v=4"},"commit":{"message":"Merge pull request #633 from djs55/dhcp\n\nvmnetd: fix DHCP response parser","shortMessageHtmlLink":"Merge pull request <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"1662969437\" data-permission-text=\"Title is private\" data-url=\"https://github.com/moby/vpnkit/issues/633\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/moby/vpnkit/pull/633/hovercard\" href=\"https://github.com/moby/vpnkit/pull/633\">moby#633</a> from djs55/dhcp"}},{"before":null,"after":"957808481b699104bec040490de6fcc62c001175","ref":"refs/heads/dhcp","pushedAt":"2023-04-11T17:38:52.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"djs55","name":"David Scott","path":"/djs55","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/198586?s=80&v=4"},"commit":{"message":"vmnetd: fix DHCP response parser\n\n1. responses can be broadcast rather than unicast\n2. check for the operation type and transaction ID\n\nSigned-off-by: David Scott <dave.scott@docker.com>","shortMessageHtmlLink":"vmnetd: fix DHCP response parser"}},{"before":"ecc9379f3a35797dc890b128151a20e3ec504d36","after":"2dc2744dd8eff6037be5c330076869c377b5b3a1","ref":"refs/heads/master","pushedAt":"2023-04-11T08:39:33.000Z","pushType":"push","commitsCount":20,"pusher":{"login":"djs55","name":"David Scott","path":"/djs55","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/198586?s=80&v=4"},"commit":{"message":"Merge pull request #632 from djs55/close-window\n\nmultiplexer: don't fail if Close() is called concurrently to Read(), Write()","shortMessageHtmlLink":"Merge pull request <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"1653654308\" data-permission-text=\"Title is private\" data-url=\"https://github.com/moby/vpnkit/issues/632\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/moby/vpnkit/pull/632/hovercard\" href=\"https://github.com/moby/vpnkit/pull/632\">moby#632</a> from djs55/close-window"}},{"before":"42a5d82a6bf1bdbdcfeb8b9eea8a35cf00f5b842","after":null,"ref":"refs/heads/close-window","pushedAt":"2023-04-11T07:52:26.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"djs55","name":"David Scott","path":"/djs55","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/198586?s=80&v=4"}},{"before":"d592267692a23477326967314f5d97c9d7a4fcf1","after":"42a5d82a6bf1bdbdcfeb8b9eea8a35cf00f5b842","ref":"refs/heads/close-window","pushedAt":"2023-04-04T10:54:10.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"djs55","name":"David Scott","path":"/djs55","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/198586?s=80&v=4"},"commit":{"message":"libproxy: don't fail if Close messages arrive out-of-order\n\nA test run demonstrated a two-way Close\n```\n[2023-04-04T05:48:03.965050200Z][com.docker.backend.exe][I] recv  3 Close\n[2023-04-04T05:48:03.965050200Z][com.docker.backend.exe][I] send  3 Close\n```\nat this point the channel refcount is 0 and the channel considered closed\n```\n[2023-04-04T05:48:03.965050200Z][com.docker.backend.exe][I] close 3 -> UDP:127.0.0.1:5201\n```\nhowever an in-progress Read call read some buffered data and sent a window advertisement:\n```\n[2023-04-04T05:48:03.965050200Z][com.docker.backend.exe][I] recv  3 Window 935323206\n```\nwhich broke the multiplexer with\n```\n[2023-04-04T05:48:03.918050500Z][com.docker.backend.exe][I] Multiplexer main loop failed with Unknown channel id 3 Window 935323206\n```\n\nPreviously it was illegal to send anything after a Close(). However it's legal\nfor clients to call Close() in goroutines while other goroutines are calling\nRead() or Write(). Each send call competes for the writeMutex, which means it's\npossible for the messages to be sent out-of-order.\n\nSince we have 2**32 channel numbers there should not be any confusion if we\nsimply expect the occasional out-of-order packet after a Close and drop it.\n\nSigned-off-by: David Scott <dave@recoil.org>","shortMessageHtmlLink":"libproxy: don't fail if Close messages arrive out-of-order"}},{"before":null,"after":"d592267692a23477326967314f5d97c9d7a4fcf1","ref":"refs/heads/close-window","pushedAt":"2023-04-04T10:46:28.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"djs55","name":"David Scott","path":"/djs55","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/198586?s=80&v=4"},"commit":{"message":"libproxy: don't fail if Close messages arrive out-of-order\n\nA test run demonstrated a two-way Close\n```\n[2023-04-04T05:48:03.965050200Z][com.docker.backend.exe][I] recv  3 Close\n[2023-04-04T05:48:03.965050200Z][com.docker.backend.exe][I] send  3 Close\n```\nat this point the channel refcount is 0 and the channel considered closed\n```\n[2023-04-04T05:48:03.965050200Z][com.docker.backend.exe][I] close 3 -> UDP:127.0.0.1:5201\n```\nhowever an in-progress Read call read some buffered data and sent a window advertisement:\n```\n[2023-04-04T05:48:03.965050200Z][com.docker.backend.exe][I] recv  3 Window 935323206\n```\nwhich broke the multiplexer with\n```\n[2023-04-04T05:48:03.918050500Z][com.docker.backend.exe][I] Multiplexer main loop failed with Unknown channel id 3 Window 935323206\n```\n\nPreviously it was illegal to send anything after a Close(). However it's legal\nfor clients to call Close() in goroutines while other goroutines are calling\nRead() or Write(). Each send call competes for the writeMutex, which means it's\npossible for the messages to be sent out-of-order.\n\nSince we have 2**32 channel numbers there should not be any confusion if we\nsimply expect the occasional out-of-order packet after a Close and drop it.\n\nSigned-off-by: David Scott <dave@recoil.org>","shortMessageHtmlLink":"libproxy: don't fail if Close messages arrive out-of-order"}},{"before":"9b95ce0c45bf3ddb72a621c9a949f1172e5c3b34","after":null,"ref":"refs/heads/update-forwarder","pushedAt":"2023-03-30T12:06:01.310Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"djs55","name":"David Scott","path":"/djs55","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/198586?s=80&v=4"}},{"before":null,"after":"9b95ce0c45bf3ddb72a621c9a949f1172e5c3b34","ref":"refs/heads/update-forwarder","pushedAt":"2023-03-30T11:47:08.553Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"djs55","name":"David Scott","path":"/djs55","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/198586?s=80&v=4"},"commit":{"message":"vpnkit-forwarder: remove dead code\n\nThis referred to AF_HVSOCK which was implemented in a patch queue\nin the linuxkit tree. The patches (from Microsoft) were upstreamed\nas AF_VSOCK.\n\nSigned-off-by: David Scott <dave@recoil.org>","shortMessageHtmlLink":"vpnkit-forwarder: remove dead code"}}],"hasNextPage":false,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAADFvp3sAA","startCursor":null,"endCursor":null}},"title":"Activity · djs55/vpnkit"}