Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Consider removing upper bound for dependencies #807

Open
2 tasks done
Viicos opened this issue Jan 25, 2024 · 0 comments
Open
2 tasks done

[FEATURE] Consider removing upper bound for dependencies #807

Viicos opened this issue Jan 25, 2024 · 0 comments

Comments

@Viicos
Copy link

Viicos commented Jan 25, 2024

Feature Request

Adding upper bounds to dependencies is generally considered a bad practice, as most of the time new "major" versions will not introduce any breaking changes. A couple reasons to not add these upper bounds:

  • each time a new "major" version is out, dependencies need to be updated. I see this is already being handled, but might not be in the future if the project lacks maintenance for some time.
  • If this isn't handled, users of djlint are bound to versions they don't control. Say I want to use a feature in html-tag-names>=0.2.0 inside my virtualenv where djlint is installed, I'd have to open a PR on this repo to loosen the dependency on html-tag-names (which currently is >=0.1.2,<0.2.0), and there're probably no breaking changes for this version bump.

This lengthy article goes into more details.

If you are ok with this, I can open a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant