New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 2.0.0 ⚠️ Help Needed! ⚠️ #168
Comments
This is started on branch https://github.com/Riverside-Healthcare/djLint/tree/beast_mode. Basically it will used modified version of pythons html module that is expanded to handle template tags. If you are familiar with python your help would be welcome! Please reach out if you'd like to build on this branch! |
Hi, what is the status of this ? I thought about some feature requests but i think your big refactoring is probably the highest priority so maybe i could find some time to assist about Python things or to tests. I tried to join the discord to talk about it but it does not work so i'm coming here. Lastly i created a tool to lint/fix class attribute value that i run just after djLint. I've used the Django template lexer to parse templates without template tag (i'm isolating them out and restore them after the lint, it's a little bit tricky) since they can contain quotes that could break my regex. Although it works pretty well, i assume this could not be efficient as your parser when parsing the whole template and not just attributes. |
Thanks, just sent you an email. |
UpdateI'm making pretty decent progress on the next major version of djLint. Some tests are stating to pass well. I will push updates in a few days. Thanks to @sveetch and others who have helped along the way so far. The formatting method of djlint is completly changing. Below there is a mini diagram showing a basic overview of how formatting is done. Inspiration for the new method comes from a few places.
Thanks to them for thinking through most of this for us :) There are a few main differences between djLint's new formatting and traditional formatters.
Planned changes
Old Formatting Method:Used the graph TD;
id1(Whitespace is removed where appropriate)-->id2(Whitespace is added where appropriate)
id2(Whitespace is added where appropriate)-->id3(Short lines consolidated back to a single line)
id3(Short lines consolidated back to a single line)-->id4(Lines are indented where appropriate);
id4(Lines are indented where appropriate)-->id5(Attributes are formatted);
New Formatting Method:Uses tokens. graph TD;
id1(html parsed into elements `parser.py`)-->id2(elements built into a tree `builder.py`)
id2-->id3(elements in tree are built into a nested list with formatting instructions `tag.py`)
id3-->id4(new list is written back to file `writer.py`)
|
How Can You HelpThe top priority is to pass the html formatting tests. Once those are in place the template syntax can be fairly easily added.
To make development easier, you can create a file called |
@dannypernik thanks, can you open a new issue for this? We can probably swap them to single quotes. We use the json5 lib for that. |
Done. Thank you! |
Feature Request
From #167
Using similar logic to linter rule H025 we can indent the templates using blocks instead of going linearly through the code line by line.
This will also match the settings using the compressor.
This will also allow us to use
{% blocktrans trimmed %}
tags, and format them.It will also fix poor formatting like this:
The text was updated successfully, but these errors were encountered: