Visit probability more than 1

[arindamsaha1507]

Perhaps the parameters need some tweaking but currently the visit probability in atleast some locations is more than one. This is caught by the error handler here:

facs/facs/base/utils.py

Line 21 in 70d60d8

raise ValueError("prob must be between 0 and 1")

which traces back to

facs/facs/base/location.py

Line 86 in 70d60d8

elif probability(visit_probability):

Should I set it to 1 if it is more, or should we change the visit times?

[djgroen]

Hi Arindam,

If it's more than one, then perhaps set the visit probability to 1, but scale up the visit time proportionally for that specific case :).

[arindamsaha1507]

I have set the probability to 1.

Do you think that scaling should be done for needs or avg_visit_times here?

facs/facs/base/location.py

Line 9 in bc0d85d

avg_visit_times = [90, 60, 60, 360, 360, 60, 60] # average time spent per visit

I am asking because the raw probability for hospitals is coming out to be 49(!) in some cases. Maybe the needs of some age groups are not proper...

What do you think?

[djgroen]

Hospitalized people will have a 12 hour need for hospitals per day, so that makes sense in that case. I think scaling up the visit duration for individuals is probably the solution here..? Cheers, Derek

…

On Thu, 8 Feb 2024, 15:19 Arindam Saha, ***@***.***> wrote: I have set the probability to 1. Do you think that scaling should be done for needs or avg_visit_times here? https://github.com/djgroen/facs/blob/bc0d85d5fe4bc67134fa20c7d0c0d4904d8cc409/facs/base/location.py#L9 I am asking because the raw probability for hospitals is coming out to be 49(!) in some cases. Maybe the needs of some age groups are not proper... What do you think? — Reply to this email directly, view it on GitHub <#55 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABCMTPJ2F4QUA3BUM2AW6XLYSTUHHAVCNFSM6AAAAABC7N4ZCSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMZUGM2DQNRZGA> . You are receiving this because you were assigned.Message ID: ***@***.***>