Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MPW_SendRecv does not return an error code #12

Open
blootsvoets opened this issue Jul 22, 2013 · 3 comments
Open

MPW_SendRecv does not return an error code #12

blootsvoets opened this issue Jul 22, 2013 · 3 comments

Comments

@blootsvoets
Copy link

This would allow error checking by the calling application. Just returning -1 is usually enough. I think a ::recv status of 0 should also be considered an error if it was successfully ::select-ed. From the recv() man page

 RETURN VALUES
 These calls return the number of bytes received, or -1 if an error
 occurred.

 For TCP sockets, the return value 0 means the peer has closed its half
 side of the connection.
@djgroen
Copy link
Owner

djgroen commented Jul 23, 2013

Hi Joris,
Has this issue been resolved with your latest commit? It looks like it may have been...?

@blootsvoets
Copy link
Author

Indeed, this issue was solved in the latest commit. However, I don't know if you want to implement a same kind of construction for the other functions? For MTO it's not necessary but maybe for other users?

@djgroen
Copy link
Owner

djgroen commented Jul 23, 2013

That's a good point. I suggest we leave this ticket open as a reminder then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants