Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hover on social media icons isn't consistent #218

Open
tim-schilling opened this issue Sep 25, 2023 · 5 comments
Open

Hover on social media icons isn't consistent #218

tim-schilling opened this issue Sep 25, 2023 · 5 comments
Assignees
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@tim-schilling
Copy link
Collaborator

tim-schilling commented Sep 25, 2023

The hover style for social media icons either changes the color to light blue (twitter), doesn't change the color (mastodon) or changes it to white (website). These should all act the same and preferably change the color to either our design's secondary color, or be made to match the twitter icon's style.

This issue is visible on https://2023.djangocon.us/organizers/

@tim-schilling tim-schilling added bug Something isn't working good first issue Good for newcomers labels Sep 25, 2023
@Neel-07
Copy link

Neel-07 commented Sep 25, 2023

Hello, I am interested in working on this issue. I have some experience with CSS and I think I can make the social media icons change color on hover. I have already forked the repository and cloned it to my local machine. Can you please assign this issue to me? Thank you for your consideration. 😊

@tim-schilling
Copy link
Collaborator Author

Done deal! Thank you @Neel-07

@Neel-07
Copy link

Neel-07 commented Sep 26, 2023

Hello @tim-schilling , I have solved the issue of the social media icons not having a consistent hover effect. I have also tested the solution on my local server and it works fine. Here is the message and the video that show my solution:

Organizers._.DjangoCon.US.-.Brave.2023-09-27.01-06-13.mp4

Please let me know what you think of my solution and if you have any suggestions for improvement. I would like to create a pull request for this issue and contribute to your project. Thank you for giving me the opportunity to contribute to your project. 😊

@tim-schilling
Copy link
Collaborator Author

@Neel-07 that looks great from a user perspective! Please open a PR. Thank you

@Neel-07
Copy link

Neel-07 commented Sep 27, 2023

Hello @tim-schilling, I have created a pull request for the issue of the social media icons not having a consistent hover effect. I hope you will review my changes and merge them soon. The link to the pull request is provided (#219) [here].

I would also like to add my name to the contributors list and be recognized for my contribution. Can I add my name to the contributors list, as I think it would be a recognition of my efforts and a motivation for me to continue contributing. I understand that this is not a trivial request, and I respect your decision either way. I just wanted to express my interest and ask for your permission.? Thank you for your cooperation. 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants