You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In the implementation of this method, it's annotation says "Close all connections owned by the pool on the given loop" and the method body is:
async def close_loop(self, loop):
"""
Close all connections owned by the pool on the given loop.
"""
if loop in self.conn_map:
for conn in self.conn_map[loop]:
conn.close()
await conn.wait_closed()
del self.conn_map[loop]
for k, v in self.in_use.items():
if v is loop:
self.in_use[k] = None
for every connection in self.conn_map[loop] here call conn.close() and await conn.wait_closed() to close the connections manually, and finally del self.conn_map[loop], that's fine.
but for the self.in_use dict, where its key is connection object and v is the loop object, here just set the value of the connection object to None, but not call k.close() and await k.wait_closed(). Is here we don't need to close it ?
The text was updated successfully, but these errors were encountered:
channels_redis/channels_redis/core.py
Line 105 in 0c27648
In the implementation of this method, it's annotation says "Close all connections owned by the pool on the given loop" and the method body is:
for every connection in self.conn_map[loop] here call conn.close() and await conn.wait_closed() to close the connections manually, and finally del self.conn_map[loop], that's fine.
but for the self.in_use dict, where its key is connection object and v is the loop object, here just set the value of the connection object to None, but not call k.close() and await k.wait_closed(). Is here we don't need to close it ?
The text was updated successfully, but these errors were encountered: