fail_silently doesn't capture exception

[gunnar-rydberg]

I get botocore.exceptions.ClientError when calling django.core.mail.message.send() with "fail_silently=True"

It seems django-ses 1.0.3 expects botocore.vendored.requests.packages.urllib3.exceptions.ResponseError ???

Some packages of interest that I use.:
boto3==1.7.75
botocore==1.10.84
django-ses==1.0.3
Django==1.11.28
M2Crypto==0.36.0
(And yes, python2)

For now I'm just making sure of capturing the ClientError myself.

[pcraciunoiu]

If you'd like to submit a PR to fix, that'd be great.

cc @GitRon or @trecouvr in case you're interested in helping out on this one

[NyanKiyoshi]

For reference:

• How django-ses handles it:
  

  django-ses/django_ses/__init__.py

  Lines 88 to 90 in e60d862

  	except Exception:
  	if not self.fail_silently:
  	raise

• How Django handles it:

  • SMTP Backend:
    https://github.com/django/django/blob/7785e03ba89aafbd949191f126361fb9103cb980/django/core/mail/backends/smtp.py#L71-L73
  • Console Backend:
    https://github.com/django/django/blob/b9cf764be62e77b4777b3a75ec256f6209a57671/django/core/mail/backends/console.py#L39-L41

Looks like that's the official expected behavior. @gunnar-rydberg, what's the use-case where you want to set fail_silently to True?

[gunnar-rydberg]

Discovered this when upgrading to latest django-ses because of the change to boto3.

I simply expect fail_silently=True to handle exception and not re-raise them as it did in previous versions of django-ses.

I want this code to capture error response from Amazon SES service. But for some reason I get botocore.exceptions.ClientError instead.

django-ses/django_ses/__init__.py

Line 214 in e60d862

except ResponseError as err:

I'll see if can have some time to investigate this further. Maybe this is due to us using oldish packages like Django 1.11?

[GitRon]

If you'd like to submit a PR to fix, that'd be great.

cc @GitRon or @trecouvr in case you're interested in helping out on this one

Hi @trecouvr - sorry but I am super busy right now 😔 No chance of me submitting anything these weeks...