Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Illegal Addresses #121

Open
JordanReiter opened this issue Jun 9, 2017 · 1 comment
Open

Illegal Addresses #121

JordanReiter opened this issue Jun 9, 2017 · 1 comment
Assignees

Comments

@JordanReiter
Copy link

Ideally, there should be a way for the email backend to gracefully ignore invalid email addresses rather than having this result in a hard error.

Alternatively, at the very least the email backend should catch responses resulting from illegal email addresses and return them as an exception that can be caught. Right now illegal email addresses raise the boto.exception.BotoServerError request, which means that any code sending out emails would have to be tightly coupled to the backend.

My recommendation would be a global setting, by default true, which ignores these errors and instead outputs a warning message (ideally specifying the illegal email in question).

I'm happy to code this myself but wanted to run it by the developers prior to writing the code.

@pcraciunoiu
Copy link
Contributor

Hi Jordan, thanks for your insightful note here. If this approach is not too tightly coupled with the internals of AWS (and thus likely to break easily within <1yr), then I say go for it. Basically, I would think it's worth the effort if the solution is relatively robust since Boto/AWS evolve over time as well.

And thanks also for offering to code this up! I'm willing to do a review, and please include tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants