Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Type hints #1090

Open
smithdc1 opened this issue Dec 5, 2020 · 2 comments · May be fixed by #1282
Open

Type hints #1090

smithdc1 opened this issue Dec 5, 2020 · 2 comments · May be fixed by #1282

Comments

@smithdc1
Copy link
Member

smithdc1 commented Dec 5, 2020

Seems to be mixed views on this generally...

What do you all think about adding some type hints to the public API?

We'd go slow and steady of course.
@cpina
Copy link
Member

cpina commented Dec 5, 2020

I haven't used type hints in Python extensively (only partially in a project) but as a user of a library I think that I would really appreciate them.

I haven't thought how hard it would be for django-crispy-forms for the public API but it might be good to consider it. My main worry is to know if the public API ends up having too many Any type everywhere and assess how much of an effort is to add and maintain.

Some days ago I saw somewhere: https://pypi.org/project/mypy-boto3-s3/ an extreme case (a package to generate hints for the S3 boto library) to see how far it can go.

@pawelad
Copy link

pawelad commented Jul 7, 2022

Related: #1282

@smithdc1 smithdc1 linked a pull request Jul 8, 2022 that will close this issue
Added Type Hints #1282
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added Type Hints django-crispy-forms/django-crispy-forms
3 participants
@cpina @pawelad @smithdc1