Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Django-FSM archived: use django-viewflow instead. #400

Closed
joshyu opened this issue Apr 10, 2024 · 7 comments
Closed

Django-FSM archived: use django-viewflow instead. #400

joshyu opened this issue Apr 10, 2024 · 7 comments
Assignees

Comments

@joshyu
Copy link
Contributor

joshyu commented Apr 10, 2024

Hi team,

Yesterday django-fsm released a new version 3.0.0 and announced that django-fsm is archived, we should use django-viewflow instead.

@fsbraun
Copy link
Sponsor Member

fsbraun commented Apr 10, 2024

@joshyu Thanks for pointing this out. We might want to consider dropping the dependency altogether. It's only a few lines of code (literally, part of the project's __init__ file plus we might want to port some of the tests.)

django-viewflow, on the other hand, is bulky, opinionated, and an overkill for the functionality we need. @marksweb @Aiky30

@Aiky30
Copy link
Contributor

Aiky30 commented Apr 10, 2024

I agree, this is a pretty bad move by the author. We could consider forking it as an alternative option too rather than making versioning bigger than it already is.

Agree completely that django-viewflow is not a direct replacement and is a bloated UI framework for django. I'm not even sure why the author is trying to push it as an alternative.

@marksweb
Copy link
Member

Someone's turned FSM into a cash cow sass product by the looks of it.

Will try to find time to look at this later.

@marksweb marksweb self-assigned this Apr 10, 2024
@fsbraun
Copy link
Sponsor Member

fsbraun commented Apr 10, 2024

I could imagine bundling the FSM functionality and versioning's conditions framework both into a small package for easier reuse, maybe even in the core - a bit like classy tags (django-conditions?).

I can imagine a decent amount of improvement in readability: fsm allows declarative rules for state transitions, the conditions framework allows declarative rules for checking availability of (any) action. I hacked something together here: https://github.com/fsbraun/django-conditions (just for getting the discussion started).

@rolandf
Copy link

rolandf commented Apr 10, 2024

And the other issue is the license. I like Django/Django cms because their license allow me to build a business around it. I tend to avoid viral licenses.

@marksweb
Copy link
Member

Quite like Fabian's idea of django-conditions. 👍

@jrief
Copy link
Contributor

jrief commented Apr 24, 2024

There is a fork of django-fsm: https://github.com/pfouque/django-fsm-2 which seems to be maintained.

I am strictly against using django-viewflow for the very simple reason, that it is not compatible with MIT/BSD/Apache - licensed software.

@jrief jrief closed this as completed May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants