Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Language menu issue #334

Open
marksweb opened this issue May 22, 2023 · 1 comment
Open

Language menu issue #334

marksweb opened this issue May 22, 2023 · 1 comment

Comments

@marksweb
Copy link
Member

Just looking at moving to cms rc3 and running versioning from master and I'm seeing the following when trying to edit a page;

  File "/Users/mwalker/Sites/consoles/.env/lib/python3.9/site-packages/cms/toolbar/toolbar.py", line 501, in _call_toolbar
    getattr(toolbar, func_name)()
  File "/Users/mwalker/Sites/consoles/.env/lib/python3.9/site-packages/djangocms_versioning/cms_toolbars.py", line 313, in populate
    self.override_language_menu()
  File "/Users/mwalker/Sites/consoles/.env/lib/python3.9/site-packages/djangocms_versioning/cms_toolbars.py", line 328, in override_language_menu
    for _item in copy(language_menu.items):
AttributeError: 'NoneType' object has no attribute 'items'
@fsbraun
Copy link
Sponsor Member

fsbraun commented May 22, 2023

This happens when only one language is configured: django CMS does not offer the language menu any more (since there are no language actions). djangocms-versioning incorrectly assumes that a language menu exists.

The fix is here: #333 . Can you take a look and review?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants