Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conflict between django 1.11 support and versioning moving beyond 1.11 #75

Open
marksweb opened this issue Feb 13, 2022 · 1 comment
Open

Comments

@marksweb
Copy link
Member

The base requirements for tests installs versioning, however versioning has dropped support for django 1.11. Specifically with it's use of django 2 url paths.

Django 1.11 either needs to be dropped or the requirements for it need to install an earlier version of versioning.

Error seen in workflows;

 File "/home/runner/work/djangocms-url-manager/djangocms-url-manager/djangocms_url_manager/admin.py", line 3, in <module>
    from djangocms_url_manager.cms_config import UrlCMSAppConfig
  File "/home/runner/work/djangocms-url-manager/djangocms-url-manager/djangocms_url_manager/cms_config.py", line 99, in <module>
    class UrlCMSAppConfig(CMSAppConfig):
  File "/home/runner/work/djangocms-url-manager/djangocms-url-manager/djangocms_url_manager/cms_config.py", line 121, in UrlCMSAppConfig
    from djangocms_versioning.datastructures import VersionableItem, default_copy
  File "/opt/hostedtoolcache/Python/3.6.15/x64/lib/python3.6/site-packages/djangocms_versioning/datastructures.py", line 8, in <module>
    from .admin import VersioningAdminMixin
  File "/opt/hostedtoolcache/Python/3.6.15/x64/lib/python3.6/site-packages/djangocms_versioning/admin.py", line 13, in <module>
    from django.urls import re_path, reverse
ImportError: cannot import name 're_path'
@Aiky30
Copy link
Contributor

Aiky30 commented Feb 22, 2022

This has been patched in the release/1.0.x stream, currently master, When this change is brought in this will no longer be an issue: #66

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants