Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix update notification on latest foss version of ckeditor 4.22.*. #668

Open
corentinbettiol opened this issue Feb 8, 2024 · 4 comments
Labels

Comments

@corentinbettiol
Copy link

Hi. Ckeditor started to show a notification yesterday:
image

It's a problem because it shows on every ckeditor box, even the ones who are part of a form on a public-facing website: every visitor of the site will see this.

image

Since we can't use versions 4.23+ (those are lts versions, which needs a license key to work, they changed the license), what we can do as a temporary fix is simply remove the notification process on the ckeditor code (gnu gpl3, we're allowed to make changes to the program).

corentinbettiol added a commit to kapt-labs/djangocms-text-ckeditor that referenced this issue Feb 8, 2024
- we can't switch to paid lts version, temp fix = hide notification
- update .pre-commit.config.yaml (fix pre-commit)
- fix pre-commit error about using double quotes instead of single ones
@matthiask
Copy link

django-ckeditor/django-ckeditor@d1cd092
Here's a different fix. All you have to do is versionCheck:false in the configuration. That being said, 4.22.1 is already known to be insecure, therefore hiding the notification isn't really fixing anything.

@fsbraun
Copy link
Sponsor Member

fsbraun commented Feb 12, 2024

@matthiask Thank you very much for the hint!! I like the system check warning.

@corentinbettiol
Copy link
Author

Thank you for this fix @matthiask!

Copy link

stale bot commented May 13, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants