-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ask: Django 4.2 support and aldryn-forms dependency #257
Comments
Hi @fsbraun , Right now we need to add django4.2 support and work with django-cms 4.0.1.x. |
@joshyu What exactly are you referring to with "version 2.1.6"? |
the latest released version which is compatible with django-cms 4.0.1.x branch is 2.1.6, so please create a branch support/django-cms-4.0.x based on tag 2.1.6(https://github.com/django-cms/djangocms-moderation/tree/2.1.6) then we can continue supporting django-cms 4.0.1.x and django 4.2 . |
Hi @joshyu, ok, now I got it. That makes sense, once there are changes introduced at any point that will not allow running moderation on django CMS 4.0. For now, I do not see the need and would advise against it to avoid the code bases drifting apart for no reason. If you think differently, you can create that branch yourself. Generally speaking: is it not much easier to move on to django CMS 4.1 and avoid reinventing everything again? Wouldn't that save quite some resources? |
Hi @fsbraun , As currently we have no much effort to do CMS upgrade, and there are some other changes due to versioning upgrade. Can you help me create this branch in current repo? I don't have the permission to do that. |
ok, but let's give it a meaningful name, like |
Hi @fsbraun , I think your suggestion is good. We can use that folder name. |
Superb! Let us keep the django CMS 4.0 compatibility here. I have already created the branch (based on 2.1.6). |
Hi team,
I found that djangocms-moderation depends on aldryn-forms which hasn't been supported by divio any more.
If we want to upgrade this addon to django 4.2 compatible, we also need to make aldryn-forms django 4.2 compatible.
How do you plan to achieve this?
The text was updated successfully, but these errors were encountered: