-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multipart upload issues with Cloudflare R2 #3873
Comments
Found some similar issues and PRs in other projects. |
Seems like this is an issue with Cloudflare not with distribution. |
It is not an issue with R2. It appears that other implemented it compatible with other S3 providers including AWS. URL encoding the multipart upload ID in the query parameter. This is either caused by R2 having differently structured IDs, or some difference in handling non-urlencoded query parameters. |
These two statements seem contradictory to me:
Note: I should clarify that I am not trying to imply that R2 is broken in any way - I'm just saying that |
Got it. |
Please do go ahead and open a PR, indeed. I can't give you guarantees if the PR will be accepted but I can tell you it'll certainly be reviewed and considered. With the PR at least we'll have something concrete to discuss :-) |
@Vad1mo can you point to the exact line/file where this URL encoding is (not) taking place? |
@ichernev no idea, I was searching for PRs on GH with same/related issues, I didn't have time to look in into docker distribution. Are you in the same boat? |
@Vad1mo well, yes. I was planning on using R2 (due to the "compatibility" with S3) but I guess it is still an open issue. I might have some time to debug the root cause of this in the coming weeks. If you figure out what the issue is (even without a patch), I can help with moving this forward. |
@tpoxa is working on a fix from our side |
I incremented the storage:
s3:
chunksize: 104857600 # 100MiB Following the thread, if I am not mistaken, the problem seems to be caused by the combining small part feature? Perhaps, this change impacts the logic of combining small parts? |
Trying to use Cloudflare R2 as a storage backend.
Small images where multipart isn't applied work fine, bigger images fail with the above error message.
The text was updated successfully, but these errors were encountered: