-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix remaining v2 -> v3 changes in docs and configuration #4250
Comments
🫠 I wonder if we should create v3-stable Mileston in GH to track there |
I think we can just reuse the 3.0.0 milestone |
I suggest we go with
I don't think it's worth it; as long as it's picked up by
Alas, no. Registry simply picks it up as the first arg to its subcommand ( distribution/registry/registry.go Lines 96 to 110 in e0a54de
I would keep it as is, personally. We could be clever but I wouldn't. Not for this release, anyway. distribution/registry/registry.go Lines 457 to 461 in e0a54de
Yep, still works for me on the v3 build; as I mentioned above it's deliberately kept simple.
I don't think we have a "canonical"/"default", but we have a couple of example config files here: https://github.com/distribution/distribution/tree/e0a54de7fc1dd9046f1d6449cc615af209003cbb/cmd/registry and more elaborate ones we use in testing here: https://github.com/distribution/distribution/tree/e0a54de7fc1dd9046f1d6449cc615af209003cbb/tests
Nope, but that'd be pretty cool and should be hard to implement actually 🤔
Nope and I wouldn't do this anyway.
there is no such thing as defaults per see at the moment. Reworking the existing code into using some sort of selected defaults would be maybe a chunky piece of work...maybe not; hard to tell but right now we read all config opts from the config file. I wouldn't do it for this release. Maybe next. Some of these suggestions are super interesting and we should do them for v4. |
Any thoughts on when v3 will be released? |
No exact ETA but wed like to get a Beta out soon, first! |
Description
I noticed some things that we need to address before v3.0.0 w.r.t. configuration or the official image, and documentation; this is just a quick list, but there may be more;
registry:2
) #4356ENTRYPOINT
and let the registry use the default location (if present)?0.1
still accurate?)containerd config default
, which dumps the default config file)?The text was updated successfully, but these errors were encountered: