Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delayed Job metric name prefixes differ from each other #291

Open
NickLarsenNZ opened this issue Aug 28, 2023 · 1 comment
Open

Delayed Job metric name prefixes differ from each other #291

NickLarsenNZ opened this issue Aug 28, 2023 · 1 comment

Comments

@NickLarsenNZ
Copy link

NickLarsenNZ commented Aug 28, 2023

The patterns I have noticed so far are:

  • delayed_job_
  • delayed_jobs_
  • delayed_failed_jobs_
image

I think these should all be delayed_job_ (without the s), then followed by the metrics specifics (eg: total, or failed_total, etc...)

@NickLarsenNZ
Copy link
Author

Maybe the first two are fine as is (jobs for aggregate, and job for per-job stats).

Sidekiq has the same:
image

But then perhaps for delayed-job it should be more like:

  • delayed_job_jobs_total
  • delayed_job_job_duration_seconds

Although it is redundant, the tool is called "delayed job", and there are jobs and per-job metrics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant