Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a way to simply add per-request/per-job metrics #206

Open
fsateler opened this issue Jan 13, 2022 · 0 comments
Open

Add a way to simply add per-request/per-job metrics #206

fsateler opened this issue Jan 13, 2022 · 0 comments

Comments

@fsateler
Copy link

fsateler commented Jan 13, 2022

Hi!

Thanks for this awesome gem.

This may be a documentation issue. I found that adding new per-request or per-job metrics is a bit annoying because:

  1. A custom collector needs to be added to pick up the new metrics.
  2. In the web case, the Middleware might be extended, or a new one created to send the new metrics
  3. In the job case, this is even worse because delayed_job (what I use) creates a dynamic class so there is no way to extend it, a new plugin is needed.

Ideally one would be able to register new metrics declaratively, and "attach" them to the current context somehow. This way the labels the default plugins use get used as well for the new metrics.

If given some guidance on how to best approach this, I'm happy to take a stab at implementing (or documenting if this is already possible)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant