Custom labels for sidekiq stats metrics

[marmaxev]

Hello.

Perhaps you should add custom labels for metrics in SidekiqStatsCollector. It would be extremely useful.

#194

[joaovictor-local]

Agree... I don't know why today it isn't obtained from the middleware 🤔

[joaovictor-local]

Agree... I don't know why today it isn't obtained from the middleware 🤔

I got confused because of the old implementation to insert custom labels in the application, this solution worked for me:
https://github.com/discourse/prometheus_exporter#client-default-labels

[marmaxev]

Yes, it is possible to insert custom labels in the application. But they are not added to the SidekiqStats metrics. As it is written here, I added custom labels and got something like this.

# HELP minor_gc_ops_total Minor GC operations by process.
# TYPE minor_gc_ops_total counter
minor_gc_ops_total{type="ruby",pid="34",foo="bar",test_label="my_label"} 59

# HELP allocated_objects_total Total number of allocated objects by process.
# TYPE allocated_objects_total counter
allocated_objects_total{type="ruby",pid="34",foo="bar",test_label="my_label"} 3344395

# HELP sidekiq_stats_dead_size Size of dead the queue
# TYPE sidekiq_stats_dead_size gauge
sidekiq_stats_dead_size 0

# HELP sidekiq_stats_enqueued Number of enqueued jobs
# TYPE sidekiq_stats_enqueued gauge
sidekiq_stats_enqueued 1

Labels are added to process metrics, but not to sidekiq stats metrics. I'd like to know if it's a bug or a feature.

[cyrilus]

Hello
the problem seem to persist. For me it's a bug