Add back username and port as AR configuration values #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Rail 6.1 the information return is from an `ActiveRecord::DatabaseConfigurations::HashConfig` object, with methods for some but not all of the configuration attributes. This fixes a bug wheree `database` and `host` had getter methods, but the `username` and `port` values did not. All values are now just fetched from the instance variable configuration_hash directly. Signed-off-by: Tim Chambers <tim@possibilogy.com>
|
I worry a bit about cross compatibility here. What is going to happen with earlier versions of rails? |
|
You separated the pre 6.1 code out, which is all that I changed. I mean I only changed post 6.0 code. And in our project we are running both 6.0 and 6.1 and now they run the same. |
|
Happy to try this, any idea why CI is failing? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Rail 6.1 the information return is from an
ActiveRecord::DatabaseConfigurations::HashConfigobject, with methods for some but not all of the configuration attributes. This fixes a bug whereedatabaseandhosthad getter methods, but theusernameandportvalues did not. All values are now just fetched from the instance variable configuration_hash directly.This fixes #187