Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ALLOWED Config Labels is inaccurate for Rails 6.1 #187

Open
tjchambers opened this issue Sep 20, 2021 · 2 comments
Open

ALLOWED Config Labels is inaccurate for Rails 6.1 #187

tjchambers opened this issue Sep 20, 2021 · 2 comments

Comments

@tjchambers
Copy link

IN the code the list of allowed config labels for ActiveRecord are username, database, host and port. These are fetched from an ActiveRecord::DatabaseConfigurations::HashConfig object using public_send. Hence they expect a public method to return those values.

In Rails 6.1.4.1 (and I believe from Rails 6.1.0.rc1 onward) only 2 of those methods exist in Rails - database and host.

So in fact username and port - while allowed - return an NoMethodError in place of the valued content.

@SamSaffron
Copy link
Member

yikes, can you try a PR to fix this?

@tjchambers
Copy link
Author

Our only issue - hopefully minor - is that the PR offered ideally would be back ported prior to the breaking naming changes in 1.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

2 participants