Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

on_connect and on_disconnect have no usage #329

Open
ejegouzo opened this issue Feb 6, 2023 · 0 comments
Open

on_connect and on_disconnect have no usage #329

ejegouzo opened this issue Feb 6, 2023 · 0 comments

Comments

@ejegouzo
Copy link

ejegouzo commented Feb 6, 2023

The 2 methods on_connect and on_disconnect defined in message_bus.rb are not called anywhere.

Why not calling these 2 methods in add_client and remove_client (lib/message_bus/connection_manager.rb) as in the following commit (made in a fork of the gem) : dexem@39fb7a1 ?

The use case to implement here is to log the start of a long polling connection and its end (using on_connect and on_disconnect) in order to count the number of long polling connections at any time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant