Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile warning on Ubuntu 20.04.2 LTS #87

Open
loeffel-io opened this issue Feb 26, 2021 · 4 comments
Open

Compile warning on Ubuntu 20.04.2 LTS #87

loeffel-io opened this issue Feb 26, 2021 · 4 comments

Comments

@loeffel-io
Copy link

CGO_ENABLED=1 go build -o finsmart-storage-api
# github.com/discord/lilliput
In file included from ../pkg/mod/github.com/discord/lilliput@v0.0.0-20210107074859-dbb0328436e8/deps/linux/include/libavutil/common.h:464,
                 from ../pkg/mod/github.com/discord/lilliput@v0.0.0-20210107074859-dbb0328436e8/deps/linux/include/libavutil/avutil.h:296,
                 from ../pkg/mod/github.com/discord/lilliput@v0.0.0-20210107074859-dbb0328436e8/deps/linux/include/libavutil/samplefmt.h:24,
                 from ../pkg/mod/github.com/discord/lilliput@v0.0.0-20210107074859-dbb0328436e8/deps/linux/include/libavcodec/avcodec.h:31,
                 from avcodec.cpp:7:
../pkg/mod/github.com/discord/lilliput@v0.0.0-20210107074859-dbb0328436e8/deps/linux/include/libavutil/mem.h:341:79: warning: ‘alloc_size’ attribute ignored on a function returning ‘int’ [-Wattributes]
  341 | av_alloc_size(2, 3) int av_reallocp_array(void *ptr, size_t nmemb, size_t size);
      |
@loeffel-io loeffel-io changed the title Compile warning on ubuntu Ubuntu 20.04.2 LTS Compile warning on Ubuntu 20.04.2 LTS Feb 26, 2021
@ldhacker
Copy link

ldhacker commented Apr 9, 2021

Apparently, they fixed this in a newer version of ffmpeg.

Line from lilliput mem.h (Line 341):
av_alloc_size(2, 3) int av_reallocp_array(void *ptr, size_t nmemb, size_t size);

Line from latest git repo on ffmpeg website (Line 348 at https://git.ffmpeg.org/gitweb/ffmpeg.git/tree/HEAD:/libavutil):
int av_reallocp_array(void *ptr, size_t nmemb, size_t size);

Commit that fixed the issue: https://git.ffmpeg.org/gitweb/ffmpeg.git/commit/4361293fcf59edb56879c36edcd25f0a91e0edf8

@ldhacker
Copy link

ldhacker commented Apr 9, 2021

I noticed that the same file is being used in the OSX version. Could a ffmpeg version bump fix this?

@SilverTee
Copy link

Same on 20.04 LTS (Focal Fossa) :(

@kim-hetrafi
Copy link

Sounds like the package distros need to be rebuilt with newer ffmpeg? up to date Arch distro affected so doesn't seem like local ffmpeg version matters

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants