Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposed API change in Muxer class #789

Open
dirkwhoffmann opened this issue Mar 9, 2024 · 0 comments
Open

Proposed API change in Muxer class #789

dirkwhoffmann opened this issue Mar 9, 2024 · 0 comments

Comments

@dirkwhoffmann
Copy link
Owner

As one of the main entry points, the Muxer class provides function

void executeUntil(Cycle targetCycle);

which runs SID to the specified target cycle and produces some sound samples on its way.

Things would become easier (e.g., the screen recorder implementation) if this function took the number of expected sound samples as an argument. In the screen recorder case, SID will have to produce 882 samples per frame for a sampling frequency of 44100Hz. The current implementation produces between 881 and 883, as the number is derived from the target cycle. This makes the current code error-prone to buffer underflows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant