Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable being able to avoid interruptions of the HTTP & HTTPS services when renewing a letsencrypt certificate #77

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kit-ty-kate
Copy link
Contributor

Fixes #76

@dinosaure
Copy link
Owner

Superseeded by #75, I added a with_lets_encrypt_certificates which should correspond to your usage.

@kit-ty-kate
Copy link
Contributor Author

That doesn't seem fixed looking at the state of the discussion in #75 (review)

@dinosaure
Copy link
Owner

That doesn't seem fixed looking at the state of the discussion in #75 (review)

Depending on what you want, the solution given by @hannesm (about challenge over a specific TLS certificate) is, of course, better by design but #75 fixe the initial issue and provide an HTTP and an HTTPS service and they are never interrupted. The only "bad" point is about the HTTP server which still open the possibility for an ACME server to communicate (and so do the challenge).

@hannesm
Copy link
Contributor

hannesm commented Jan 11, 2023

@kit-ty-kate I'm not entirely sure, but I thought @dinosaure implemented something so that all non-let's-encrypt-requests are redirected to the actual http server. though I haven't carefully read that part of the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature request] Avoid interruptions of the HTTP & HTTPS services when renewing the letsencrypt certificate
3 participants